feat: sync Node.js SDK with Python SDK - #136
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Add Finetuning.listModels() method (mirrors Python SDK's list_models()) - Fix FinetuningCreateParams.batchSize default from 1 to 'auto' (matches Python SDK) - Add 'datasets' alias on VlmRun client for parity with Python SDK's plural naming - Add 'domain' field to PredictionResponse type (present in Python SDK) - Update test expectations for new batchSize default Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the Node.js SDK with the Python SDK to close feature and behavior gaps identified during a cross-SDK review.
Changes:
Finetuning.listModels()— New method mirroring Python SDK'slist_models(). CallsGET /fine_tuning/modelswith pagination params.batchSizedefault →"auto"— TheFinetuning.create()default forbatchSizewas1; Python SDK uses"auto". Updated to match.client.datasetsalias — Python SDK exposesclient.datasets(plural). Node.js only hadclient.dataset. Addeddatasetsas an alias pointing to the sameDatasetsinstance (backward compatible).PredictionResponse.domain— Added optionaldomainfield to match the Python SDK'sPredictionResponsetype.Review & Testing Checklist for Human
batchSizedefault change is intentional and acceptable: changing from1to"auto"is a behavioral change for any caller relying on the default. Confirm this won't break downstream consumers before merging.listModels()has no unit test: verify the method signature and endpoint path (GET /fine_tuning/models) are correct against the backend API spec. Consider adding test coverage.npm run test:integrationagainst a live environment to verifylistModels()and thebatchSize: "auto"default work end-to-end.Notes
client.dataset(singular) is preserved for backward compatibility;client.datasetsis an alias to the same instance.PredictionResponse.domainfield is optional so it is purely additive and non-breaking.Link to Devin session: https://app.devin.ai/sessions/fac4bac963184905b3ca00caeadea6d4