Correct sdp-expectation-notifications docs: drop coverage, alert naming, destination semantics - #19
Merged
Conversation
…ng, destination semantics Seven documentation corrections grounded in two live verification sessions (2026-07-26 drop/destination testing, 2026-07-17/18 hygiene build): the hook covers drop expectations identically to warn, not just warn; "Alert v2" renamed to "Databricks SQL alert" to match current Databricks naming; notification destinations clarified as a webhook wrapper, not a hook delivery path or a Slack-without-a-webhook shortcut; readers with no webhook target are now steered to deploy the backstop alone; the backstop cron is tied to pipeline mode; the platform's teardown grace period is stated as an unestablished bound instead of a false "roughly 20 seconds"; and the skill documents a CLI gotcha in notification-destinations create. No pipeline code, YAML defaults, or test behavior changed. Also cleans up two ROADMAP.md Future Ideas entries: fills in the placeholder Pre-commit Hooks item with a proper scoped proposal, and adds a new Shared Bundles Support idea for consuming an external shared-bundle path via sync.paths/include. Bumps to v1.12.1 (patch) per RELEASING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #
Summary
Documentation-only pass on the
sdp-expectation-notificationsasset: seven corrections grounded in two live verification sessions (2026-07-26 drop/destination testing, 2026-07-17/18 hygiene build). No pipeline code, YAML defaults, or test behavior changed. Also includes two small ROADMAP.md cleanups and finalizes v1.12.1.Changes
failed_records > 0and never inspects the expectation's action type, sowarnanddroprules notify identically; the README previously framed the pattern as WARN-only. Adds the lived 2026-07-26 numbers (drop expectation matching the WARN row's shape,dropped_recordsfield, additive backstop sum).alerts-v2kept only where it names an actual CLI command.user_emailshare an address.databricks notification-destinations create's misleading warning/empty echo, so an agent scripting it doesn't mistake success for failure.Change Area
template/, schema, helpers)assets/<name>/)Configuration Axes Affected
databricks_template_schema.json)library/helpers.tmpl)Testing
pytest tests/ -V) — 2446 passed, 163 skipped, unchanged from the pre-edit baselineRelease (if this PR cuts a release)
CHANGELOG.mdfinalized:[Unreleased]renamed to[1.12.1] - 2026-07-26, fresh empty[Unreleased]added above1.12.1(pyproject.tomlandtemplate/{{.project_name}}/bundle_init_config.json.tmpl)tests/test_release_metadata.py)Checklist
{{ }}blocks).tmplfiles appear in generated output