Unroll MIN as the straight ?: construct#13
Open
yanick wants to merge 1 commit into
Open
Conversation
Considering that not all compilers give us MIN implicitly, and since it's only at one place in the code, losing the MIN shouldn't be too high a price to pay, readability-wise, for portability.
|
Just out of curiosity, which common compiler's don't give us MIN? I've been reading through the code in this repo and your PR sparked my interest. Thanks in advance! |
Author
|
Look at the failures of Escape::Houdini 0.1.2 (my Perl wrapper for the houdini lib) at http://www.cpantesters.org/distro/E/Escape-Houdini.html As usual, it's the windows compiler that seems to be causing problems, the naughty git. :-) |
|
Thanks for the explanation! I'm going to maintain an updated fork of @vmg's project over at christianbundy/houdini, and I've merged your commit. |
Author
|
Sweet. The Perl module was using my own fork. I'm glad to ear I'll be able to just point to yours and have one less repo to worry about. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering that not all compilers give us MIN implicitly, and since it's only at one place in the code, losing the MIN shouldn't be too high a price to pay, readability-wise, for portability.