Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Non-fips Dockerfile.Signed-off-by: Abhay Sharma <shabhay@vmware.com>#26

Open
shabhay wants to merge 4 commits into
vmware-archive:masterfrom
shabhay:non-fips
Open

Non-fips Dockerfile.Signed-off-by: Abhay Sharma <shabhay@vmware.com>#26
shabhay wants to merge 4 commits into
vmware-archive:masterfrom
shabhay:non-fips

Conversation

@shabhay

@shabhay shabhay commented Jun 15, 2022

Copy link
Copy Markdown

No description provided.

@vmwclabot

vmwclabot commented Jun 15, 2022

Copy link
Copy Markdown

@shabhay, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot

vmwclabot commented Jun 17, 2022

Copy link
Copy Markdown

@shabhay, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

slk244
slk244 reviewed Jun 21, 2022
View reviewed changes
Comment thread Dockerfile Outdated

COPY ./ /app/
WORKDIR /app
FROM photon:3.0-20200424

@slk244 slk244 Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets put this file inside new folder.
something like this nonfips/Dockerfile

@slk244 slk244 Jun 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fips one as well in new directory
fips/Dockerfile

@vmwclabot

vmwclabot commented Jun 21, 2022

Copy link
Copy Markdown

@shabhay, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

slk244
slk244 reviewed Jun 21, 2022
View reviewed changes
Comment thread Dockerfile Outdated
COPY ./ /app/
WORKDIR /app
FROM photon:3.0-20200424
USER root

@slk244 slk244 Jun 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets revert this file right?

@shabhay shabhay Jun 21, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will revert it

@vmwclabot

vmwclabot commented Jun 21, 2022

Copy link
Copy Markdown

@shabhay, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@slk244 slk244 slk244 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shabhay @vmwclabot @slk244