Skip to content
This repository was archived by the owner on Mar 15, 2021. It is now read-only.

add systemd units#94

Open
tompscanlan wants to merge 3 commits into
vmware-archive:masterfrom
tompscanlan:systemd-units
Open

add systemd units#94
tompscanlan wants to merge 3 commits into
vmware-archive:masterfrom
tompscanlan:systemd-units

Conversation

@tompscanlan

Copy link
Copy Markdown
Contributor

add systemd start up configuration for liota

Comment thread setup.py
(os.path.abspath(os.sep) + '/../etc/liota/packages/edge_systems/dell5k',
['packages/edge_systems/dell5k/edge_system.py']),
(os.path.abspath(os.sep) + '/../etc/liota/scripts',
(os.path.abspath(os.sep) + '/../etc/liota/scripts',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new dependencies in Manifest.in file

Comment thread scripts/liotad.service Outdated
ExecStart=/etc/liota/packages/liotad.py

[Install]
WantedBy=multi-user.target No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I`m not sure but I think better to add a new line in both the files liotad.service & liotad.socket

http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

@tompscanlan

Copy link
Copy Markdown
Contributor Author

Fixed endlines and added deps to the manifest file

Comment thread README.md Outdated
### On systemd based systems:

```bash
$ systemctl enable liota.socket

@KohliDev KohliDev Apr 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be liotad.service & liotad.socket?

Also, I cloned your branch and will try out this commands on Fedora VM. What is the prime job of these commands? Also, I think if liota daemon gets started then we won`t require liotad.socket to be started explicitly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tompscanlan

It'll be very helpful if you can provide some information about this change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Fixing that.

@KohliDev KohliDev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tompscanlan Can you please answer the questions marked in the pull request?

@KohliDev

Copy link
Copy Markdown
Contributor

@tompscanlan any update on this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants