Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

Ensure upload of images actually succeeds #150

Description

@mkesper

Whether the upload is using curl as right now or the method proposed in #119, it should always check that there were no errors.
Right now, the result of the curl command isn't checked at all:
OvfManager.rb:
``

    system("#{downloadCmd} | #{uploadCmd}", :out => "/dev/null")
    
    keepAliveThread.kill
    keepAliveThread.join
    
    progress += (90.0 / result.fileItem.length)
    nfcLease.HttpNfcLeaseProgress(:percent => progress.to_i)
  end

  nfcLease.HttpNfcLeaseProgress(:percent => 100)
  raise nfcLease.error if nfcLease.state == "error"

It should also raise if the system command returns an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions