Update dependencies#465
Open
antoninbas wants to merge 2 commits into
Open
Conversation
Member
antoninbas
commented
Jun 5, 2026
antoninbas
commented
- Update go to 1.26
- Update go.mod dependencies
* Update go to 1.26 * Update go.mod dependencies Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
commented
Jun 5, 2026
| k8s.io/component-base v0.31.0 | ||
| k8s.io/klog/v2 v2.130.1 | ||
| go.uber.org/mock v0.6.0 | ||
| google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af |
Member
Author
There was a problem hiding this comment.
this is required by K8s when bumping up to 0.36.1 modules
sarama v1.50.2 enables ApiVersionsRequest by default (KIP-511): the client now sends an ApiVersionsRequest to the broker as part of the initial connection handshake, before any MetadataRequest. The test was using seedBroker.Returns() which queues responses in FIFO order. The mock broker consumed the queued MetadataResponse for the ApiVersionsRequest, leaving nothing for the subsequent MetadataRequest — causing both sides to block indefinitely. Replace Returns() with SetHandlerByMap() so each request type is routed to the correct response handler regardless of arrival order. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.