Skip to content

Adiciona compatibilidade com o mac#3

Open
victoralcan wants to merge 2 commits into
masterfrom
feat/add-mac-compatibility
Open

Adiciona compatibilidade com o mac#3
victoralcan wants to merge 2 commits into
masterfrom
feat/add-mac-compatibility

Conversation

@victoralcan
Copy link
Copy Markdown

No description provided.

Comment thread scripts/pre-commit Outdated

convert_all_xls() {
for file in $(git diff --name-status --staged | grep '^A' | grep -Po '[^\t]*$' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^A' | awk '{print $NF}' | grep '.xls'); do
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for file in $(git diff --name-status --staged | grep '^A' | awk '{print $NF}' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^A' | grep -o '\S*$' | grep '.xls'); do

Comment thread scripts/pre-commit Outdated
done

for file in $(git diff --name-status --staged | grep '^M' | grep -Po '[^\t]*$' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^M' | awk '{print $NF}' | grep '.xls'); do
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for file in $(git diff --name-status --staged | grep '^M' | awk '{print $NF}' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^M' | grep -o '\S*$' | grep '.xls'); do

Comment thread scripts/pre-commit Outdated
done

for file in $(git diff --name-status --staged | grep '^D' | grep -Po '[^\t]*$' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^D' | awk '{print $NF}' | grep '.xls'); do
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for file in $(git diff --name-status --staged | grep '^D' | awk '{print $NF}' | grep '.xls'); do
for file in $(git diff --name-status --staged | grep '^D' | grep -o '\S*$' | grep '.xls'); do

Comment thread ummap.c Outdated
//#if #system(bsd)
|| i->si_code == SEGV_MAPERR
#endif
|| i->si_code == SEGV_MAPERR /* macOS, OpenBSD and others */
Copy link
Copy Markdown
Member

@alfoltran alfoltran Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não fazer isso!!! Coloque o identificador do MAC aqui também.

Comment thread ummap.c Outdated
}

#ifdef SIGBUS
/* macOS raises SIGBUS instead of SIGSEGV on some memory access faults */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não comentar sobre MAC. SImplesmente comente que pode haver este sinal caso esteja definido.

Comment thread ummap.c Outdated
found:
if (um->handler(um, (char *) um->addr + (o & -um_page_sz)) >= 0)
if (um->handler(um, (char *) um->addr + (o & -um_page_sz)) >= 0) {
/* Re-arm both SIGSEGV and SIGBUS (macOS may raise either) */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não comentar sobre MAC. SImplesmente comente que pode haver este sinal caso esteja definido.

Comment thread CMakeLists.txt Outdated
Comment on lines +8 to +9
# On macOS, libm is part of libSystem and does not need explicit linking
if(NOT APPLE)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# On macOS, libm is part of libSystem and does not need explicit linking
if(NOT APPLE)
# On macOS, libm is part of libSystem and does not need explicit linking
if (NOT APPLE)

@victoralcan victoralcan marked this pull request as ready for review March 18, 2026 18:54
@victoralcan victoralcan requested a review from alfoltran March 18, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants