Open
Conversation
kimbylr
commented
Jan 11, 2021
kimbylr
commented
Jan 11, 2021
dafrie
reviewed
Feb 9, 2021
dafrie
reviewed
Feb 9, 2021
Contributor
dafrie
left a comment
dafrie
left a comment
There was a problem hiding this comment.
I am terribly sorry for the slow review!
Very nice work, thank you so much! I left only minor comments. There is a small annoying change we need to make unfortunately. In contrast to what we agreed on originally, the new components should be displayed for "subchapter cards", since we will split the long chapters of Book 2 into subchapters as well. So in theory, there will not be any main chapters with direct components anymore.
Author
|
Well… I wasn't that fast either 🙈 I changed the query to get all the data only on subchapters instead of chapters. Does this seem right to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.