Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

feat: light, color and texture XML#70

Merged
Mariana-rc01 merged 6 commits into
mainfrom
mari/4phase
May 8, 2025
Merged

feat: light, color and texture XML#70
Mariana-rc01 merged 6 commits into
mainfrom
mari/4phase

Conversation

@Mariana-rc01

Copy link
Copy Markdown
Collaborator

No description provided.

@voidbert voidbert left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just some suggestions to improve code quality.

Comment thread include/engine/scene/light/Light.hpp Outdated
Comment thread src/utils/XMLUtils.cpp Outdated
Comment thread include/engine/scene/Entity.hpp Outdated
Comment thread src/engine/scene/light/LightFactory.cpp Outdated
Comment thread include/engine/scene/light/LightFactory.hpp Outdated
Comment thread include/engine/scene/light/Light.hpp Outdated
Comment thread src/engine/scene/light/LightFactory.cpp Outdated
Comment thread src/engine/scene/light/LightFactory.cpp Outdated
Comment thread src/engine/scene/Entity.cpp Outdated
@Mariana-rc01 Mariana-rc01 requested a review from voidbert May 7, 2025 19:02
@Mariana-rc01 Mariana-rc01 merged commit 29494e3 into main May 8, 2025
3 checks passed
@Mariana-rc01 Mariana-rc01 deleted the mari/4phase branch May 8, 2025 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants