Skip to content

Performance Improvement and Robustness #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeanderSilur wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Performance Improvement and Robustness #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eb732b
Performance Improvement and Robustness
Sep 1, 2020
25e4eba
fixed min
Sep 1, 2020
6a3fb29
another typo
Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions fitCurves.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def computeMaxError(points, bez, parameters):
maxDist = 0.0
splitPoint = len(points)/2
for i, (point, u) in enumerate(zip(points, parameters)):
dist = linalg.norm(bezier.q(bez, u)-point)**2
dist = ((bezier.q(bez, u) - point) ** 2).sum(-1)
if dist > maxDist:
maxDist = dist
splitPoint = i
Expand All @@ -157,5 +157,7 @@ def computeMaxError(points, bez, parameters):


def normalize(v):
return v / linalg.norm(v)

magnitude = sqrt(v.dot(v))
if magnitude < finfo(float).eps:
return v
return v / magnitude