fix/go-mod-tree#1
Merged
Merged
Conversation
Fix universal archive layout and rebuild reconciliation Make universal zip and tar.gz artifacts raw, host-independent global rows, and keep Go import-path rewriting limited to the Go proxy module zip. Bump the universal artifact format versions so stale rewritten or listener-specific rows cannot shadow current archive metadata. Teach rebuild-cache to reconcile the full desired artifact set: create missing rows, update drifted digests, prune legacy listener-specific universal rows, and persist host/artifact-layout fingerprints for startup reconciliation. Serve archive downloads only from current global-format universal artifacts so old rows cannot be selected before background cleanup completes. Also fail Brother blob fetches on real read errors while still skipping genuinely missing blobs. Update OpenAPI and README/overlay docs for the raw universal archive contract, and add regression coverage for rebuild reconciliation, stale archive serving, global storage metadata, and Brother blob read errors.
add Content-Disposition header to artifact downloads - Extend partialResp to accept and emit a disposition value - Set attachment filename per ecosystem: package-qualified name for universal archives, key@version for Go proxy artifacts - Replace rate-limit range test with Content-Disposition coverage for both universal and Go proxy endpoints - Update overlay README and OpenAPI specs to document the Content-Disposition response header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix universal archive layout and download headers
Summary
.zipand.tar.gzartifacts raw, host-independent global rows, with Go import-path rewriting limited to Go proxy module zips.rebuild-cacheand startup cleanup create missing rows, update drifted digests, prune legacy listener-specific universal rows, and persist host/artifact layout fingerprints.Content-Dispositionfilenames for universal archives and Go proxy zip downloads, including range responses.Testing
go test ./...git diff --check origin/main..HEADChecklist
target/apihad no diff.