feat[gpu]: sliced validity in Arrow device export#8318
Merged
Conversation
cdee93f to
da7278c
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
216.9 ns | 275.3 ns | -21.19% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
278.6 ns | 336.9 ns | -17.31% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
342.2 ns | 400.6 ns | -14.56% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
46.8 µs | 31.9 µs | +46.83% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
198.2 µs | 162 µs | +22.31% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
213.4 µs | 177.2 µs | +20.41% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/sliced-varbinview-e2e (f8d19e7) with develop (031fb76)
da7278c to
795fe55
Compare
Add cuDF e2e coverage for sliced and multi-buffer Utf8View arrays, including non-ASCII values and sliced null validity. Keep bit-offset validity repacking on the CUDA stream for Arrow Device export, with focused tests and a CUDA benchmark for the repack path. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
795fe55 to
6ce4bd7
Compare
robert3005
reviewed
Jun 9, 2026
Rebuild the validity bitmap 64 bits at a time with a funnel shift over two adjacent input words, masking the leading offset bits and the trailing length bits, instead of testing bits one by one. Launch one word per thread with a grid-stride loop so warp accesses coalesce. Repack of 100M bits on GH200 drops from 140us to 21us (6.7x). Also derive the output size from len + arrow_offset instead of taking a redundant output_bytes parameter, drop the now-unneeded output memset (every word is written, edge masks zero the padding), bound the host-to-device copy to the slice's bytes via shrink_offset, and cover negative-shift and multi-word offsets in the repack tests. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Contributor
Author
|
GH 200: |
robert3005
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.