Skip to content

Optimize fsst_compress_offsets_overflow_i32 by 2X locally#8324

Merged
robert3005 merged 1 commit into
developfrom
adamg/optimize-test-fsst-overflow
Jun 9, 2026
Merged

Optimize fsst_compress_offsets_overflow_i32 by 2X locally#8324
robert3005 merged 1 commit into
developfrom
adamg/optimize-test-fsst-overflow

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Optimize the infamous fsst_compress_offsets_overflow_i32 test by dropping the symbol table - instead compressing with an empty symbol table to get constant escapes.

Locally this change drops the test's runtime from 136s to 57s (in normal test profile), which should have a real impact on our CI runtimes.

This change is provided by the new fable-5 model.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team, 0ax1 and joseph-isaacs June 9, 2026 19:51
@AdamGS AdamGS added the changelog/chore A trivial change label Jun 9, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.56%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
✅ 1523 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 275.3 ns 216.9 ns +26.89%
Simulation bitwise_not_vortex_buffer_mut[1024] 336.9 ns 278.6 ns +20.94%
Simulation bitwise_not_vortex_buffer_mut[2048] 400.6 ns 342.2 ns +17.05%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/optimize-test-fsst-overflow (c00b58c) with develop (4b6c382)

Open in CodSpeed

@robert3005 robert3005 merged commit f7f6d10 into develop Jun 9, 2026
73 of 74 checks passed
@robert3005 robert3005 deleted the adamg/optimize-test-fsst-overflow branch June 9, 2026 21:40
@joseph-isaacs

joseph-isaacs commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

We could run this in release with debug assert too?

@0ax1

0ax1 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thaaaank you

@AdamGS

AdamGS commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@joseph-isaacs we can, last time I looked running tests in release was much slower and specializing one test is brittle, I think this already makes it much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants