Add basic JSONBench-based benchmark#8340
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
6b912e1 to
1e1a170
Compare
Merging this PR will degrade performance by 10.62%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
31.9 µs | 46.8 µs | -31.82% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.0)] |
845.8 µs | 1,024.6 µs | -17.45% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
177.2 µs | 213.3 µs | -16.95% |
| ❌ | Simulation | decompress_rd[f32, (100000, 0.0)] |
499.5 µs | 587 µs | -14.91% |
| ❌ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
300 µs | 349.9 µs | -14.25% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274.7 µs | 309.5 µs | -11.26% |
| ⚡ | Simulation | decompress_rd[f64, (100000, 0.01)] |
981.6 µs | 846 µs | +16.03% |
| ⚡ | Simulation | decompress_rd[f64, (100000, 0.1)] |
981.5 µs | 846 µs | +16.02% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/compress-json-bench (1e1a170) with adamg/json-arrow-export (5430d3a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a very naive "compress jsonbench as strings" benchmark. The use of
vortex_jsonrequired some API changes to theDatasetAPI, but I think this is relatively straight forward.This is a step towards more variant-focused benchmarks and functionality, trying to get the boilerplate out of the way before I try and land bigger changes.
This PR builds on top of #8339, which includes some missing functionality for
vortes-json.