Skip to content

Stats predicate satisfiers#8344

Open
gatesn wants to merge 1 commit into
developfrom
ngates/stats-rewrite-satisfiers
Open

Stats predicate satisfiers#8344
gatesn wants to merge 1 commit into
developfrom
ngates/stats-rewrite-satisfiers

Conversation

@gatesn

@gatesn gatesn commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Add satisfier rewrites for binary comparisons, boolean composition, and between expressions. The rewrites prove predicates true from min/max stats and add null/NaN guards where comparisons require every row to evaluate true.

@gatesn gatesn added the changelog/feature A new feature label Jun 10, 2026
@gatesn gatesn marked this pull request as ready for review June 10, 2026 20:06
@gatesn gatesn requested review from a team and robert3005 June 10, 2026 20:06
@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.6%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 2 regressed benchmarks
✅ 1530 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 215.3 ns 244.4 ns -11.93%
Simulation chunked_varbinview_canonical_into[(100, 100)] 274.4 µs 309.3 µs -11.27%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/stats-rewrite-satisfiers (84bfe64) with develop (3d7bbfb)

Open in CodSpeed

Add satisfier rewrites for binary comparisons, boolean composition, and between expressions. The rewrites prove predicates true from min/max stats and add null/NaN guards where comparisons require every row to evaluate true.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/stats-rewrite-satisfiers branch from 7364fa8 to 84bfe64 Compare June 10, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant