Fix f-string quoting in update_config.py - #51
Open
astronomyk wants to merge 2 commits into
Open
astronomyk wants to merge 2 commits into
astronomyk wants to merge 2 commits into
Conversation
Configure pyproject.toml with all dependencies, including PyPROPER3 sourced from the university wheel server. Add missing util/__init__.py, LICENSE, .gitignore updates for build artifacts, and build docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use double quotes for f-strings that contain single-quoted dict key access, fixing a syntax error on Python < 3.12. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
This PR mixes two things:
I have implemented the fix separately (here: 8b60650). The second part requires more work on my side: setting up the wheel server that host PyPROPER, and thus make HEEPS pip installable. My impression is that the new folder docs containing 'building_wheels.md', although useful explanation (it will be useful to me when I try to make HEEPS pip installable), should not be merged to the HEEPS repo. Unless, you advise otherwise in the coming days, I would close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_config.pythat use single-quoted dict key access inside the expressionSyntaxErroron Python < 3.12Test plan
from heeps.config import update_configimports without error on Python 3.10/3.11🤖 Generated with Claude Code