fix(slo): align latency buckets with SLO, zero-fill 5xx ratio - #138
Merged
Conversation
Two latent rule bugs surfaced by evaluating every dashboard panel: - slo:latency:ratio7d filters le="0.2" but the request-latency histogram used default client buckets, which jump 0.1 -> 0.25; the series has been empty since the rule was written, taking the latency error-budget panel with it. The histogram now declares explicit buckets including the 0.2 SLO boundary. - slo:error_rate:actual_5xx_ratio7d produced an empty vector (panel "No data") whenever zero 5xx requests existed -- the healthy case. The numerator now falls back to vector(0), so a clean stack reads 0. Verified live: promtool validates the rules; after rebuilding the api image all three previously empty series evaluate (5xx ratio = 0, latency ratio converging to 1.0 as the rate window fills); backend tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two latent rule bugs surfaced by evaluating every dashboard panel:
Verified live: promtool validates the rules; after rebuilding the api image all three previously empty series evaluate (5xx ratio = 0, latency ratio converging to 1.0 as the rate window fills); backend tests pass.