Support query_single via conflict_resolution#19
Merged
Conversation
Sheerwin02
reviewed
Feb 8, 2026
Comment on lines
159
to
166
| if self.nodes.is_empty() { | ||
| // There's no tree, if there's just one rect, do a hit | ||
| // test for it. | ||
| if let Some(rect) = self.rects.first() | ||
| && hit_condition(rect, &target) | ||
| { | ||
| hits.push(RectId(0)); | ||
| } |
Contributor
There was a problem hiding this comment.
Will it have case more than one rect before build?
Member
Author
There was a problem hiding this comment.
This will only happen if the build function is not being called. In that case, querying is invalid anyways xd. This is because internal nodes are always N-1 (as defined in the algo)
Now that you mention this, I can make a follow up PR to create a spatree builder to ensure correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stepping stone for #17