Skip to content

Fix scale factor bug#20

Merged
nixonyh merged 3 commits intomainfrom
nixon/scale-factor-fix
Feb 9, 2026
Merged

Fix scale factor bug#20
nixonyh merged 3 commits intomainfrom
nixon/scale-factor-fix

Conversation

@nixonyh
Copy link
Member

@nixonyh nixonyh commented Feb 7, 2026

  • Double down on the builder method for widget creation

- Double down on the builder method for widget creation
@nixonyh nixonyh requested a review from Sheerwin02 February 7, 2026 12:14
@nixonyh nixonyh enabled auto-merge (squash) February 7, 2026 12:15
Copy link
Contributor

@Sheerwin02 Sheerwin02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just that when I go through, since currently widget have pub children: Vec, so in the future if remove a node from the tree need to remove it from the widget's Vec too, cause I suspect if a node is removed from the Rectree using tree.remove(), the parent widget's Vec in the World will still contain the deleted NodeId.

@nixonyh
Copy link
Member Author

nixonyh commented Feb 8, 2026

Just that when I go through, since currently widget have pub children: Vec, so in the future if remove a node from the tree need to remove it from the widget's Vec too, cause I suspect if a node is removed from the Rectree using tree.remove(), the parent widget's Vec in the World will still contain the deleted NodeId.

True, but there's no use case for it in this example, similar to when u did yr PR, it wasn't implemented too because it won't/can't be used due to lack of interactivity.

Update layout_basic.rs
@nixonyh nixonyh force-pushed the nixon/scale-factor-fix branch from a495cc2 to 47c7252 Compare February 9, 2026 01:59
@nixonyh nixonyh requested a review from Sheerwin02 February 9, 2026 06:17
Copy link
Contributor

@Sheerwin02 Sheerwin02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid for an example!

@nixonyh nixonyh merged commit 29f557d into main Feb 9, 2026
7 checks passed
@nixonyh nixonyh deleted the nixon/scale-factor-fix branch February 9, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants