fix: [CN-68] update TEXT and JSON encoders to correctly handle nil input#65
Merged
vpakhuchyi merged 2 commits intomainfrom Nov 12, 2025
Conversation
nil …nil input
There was a problem hiding this comment.
Pull Request Overview
This PR refactors nil value handling by moving the logic from the Processor.Any method into the individual encoders (TEXT and JSON), ensuring each encoder handles invalid reflect.Value objects appropriately.
Key Changes:
- Removed nil check from
Processor.Any()method - Added
!f.IsValid()checks to both TEXT and JSON encoderEncode()methods - Added comprehensive test coverage for nil handling with both encoder types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| processor.go | Removed nil check from Processor.Any() method, delegating responsibility to encoders |
| internal/encoder/text_encoder.go | Added nil/invalid value check at the start of Encode() method, returning "nil" for TEXT format |
| internal/encoder/json_encoder.go | Added nil/invalid value check at the start of Encode() method, returning "null" for JSON format |
| processor_test.go | Added test cases for nil value handling with both JSON (default) and TEXT encoders |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Link to the related ticket
https://censor.atlassian.net/browse/CN-68
Description of changes
Update TEXT and JSON encoders to correctly handle
nilinput.Checklist
Please ensure that your pull request complies with the following requirements: