fix: [CN-69] respect struct json tags in JSON encoder with UseJSONTagName enabled#66
Merged
vpakhuchyi merged 1 commit intomainfrom Nov 13, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the UseJSONTagName configuration option in the JSON encoder, allowing struct fields to use their json tag names instead of Go field names when encoding.
- Adds logic to parse and respect
jsonstruct tags in the JSON encoder - Implements proper handling of tag options, dash tags (
json:"-"), and fallback to field names - Updates documentation to clearly explain the feature behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/encoder/json_encoder.go | Implements JSON tag parsing logic in getStructFields method, adds UseJSONTagName configuration to encoder initialization, includes gocognit suppression for increased complexity |
| internal/encoder/json_encoder_test.go | Adds comprehensive test coverage for UseJSONTagName feature with multiple edge cases including aliased tags, skipped fields, empty tag names, and default behavior |
| docs/index.md | Updates configuration documentation to accurately describe the UseJSONTagName option behavior, clarifying how it mirrors Go's encoding/json package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Link to the related ticket
https://censor.atlassian.net/browse/CN-69
Description of changes
When
UseJSONTagNameconfiguration option is enabled JSON encoder shall usejsonstructure tags instead of field names.Checklist
Please ensure that your pull request complies with the following requirements: