refs #10 - Add command to start a workflow#11
Open
mventuravoyageprive wants to merge 3 commits intopocfrom
Open
refs #10 - Add command to start a workflow#11mventuravoyageprive wants to merge 3 commits intopocfrom
mventuravoyageprive wants to merge 3 commits intopocfrom
Conversation
jrmbrgs
suggested changes
Oct 13, 2017
| */ | ||
| public static function start(string $workflowName, string $workflowId, array $payloadHash) | ||
| { | ||
| $brokers = 'localhost'; |
Library/Commands/Workflow.php
Outdated
| public static function start(string $workflowName, string $workflowId, array $payloadHash) | ||
| { | ||
| $brokers = 'localhost'; | ||
| $msg = '{"contract":"'.$workflowId.'", "type" : "WF-CONTROL", "action":"start"}'; |
Contributor
There was a problem hiding this comment.
should be abstracted by the dto
| $msg = '{"contract":"'.$workflowId.'", "type" : "WF-CONTROL", "action":"start"}'; | ||
|
|
||
| //send message with givens params | ||
| $kafkaProducer = new \RdKafka\Producer(); |
Contributor
There was a problem hiding this comment.
should be in di or even abstracted
Library/Commands/Workflow.php
Outdated
| //send message with givens params | ||
| $kafkaProducer = new \RdKafka\Producer(); | ||
| $kafkaProducer->addBrokers($brokers); | ||
| $topicName = 'disturb-' . $workflowName . '-manager'; //xxx create service to manage topic name |
mventuravoyageprive
force-pushed
the
dist_10
branch
from
15a6b1a to
28ccf0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10