Open
Conversation
Travis tests have failedHey mbrenguier, 1st Buildvendor/bin/phpcs --standard=./phpcs.xml ./Library/vendor/phpunit/phpunit/phpunit -c Tests/phpunit.xml |
Travis tests have failedHey mbrenguier, 1st Buildvendor/bin/phpcs --standard=./phpcs.xml ./Library/vendor/phpunit/phpunit/phpunit -c Tests/phpunit.xml |
jrmbrgs
approved these changes
Feb 15, 2018
Library/Client/DisturbStarter.php
Outdated
| * @param String $topicName topic name | ||
| * | ||
| */ | ||
| public static function start(string $workflowId, array $payloadHash, string $brokers, string $topicName) |
Contributor
There was a problem hiding this comment.
the client (turbo) should use https://github.com/vpg/disturb/blob/beta/Library/Topic/TopicService.php to define the topic name according to the client workflow name and the disturb topic naming logic
Library/Client/DisturbStarter.php
Outdated
| use \Phalcon\Mvc\User\Component; | ||
| use \Vpg\Disturb\Message; | ||
|
|
||
| class DisturbStarter extends Component |
Contributor
There was a problem hiding this comment.
maybe rename DisturbStarter in command to make the use more readable :
\Disturb\Client\Command::start(...)
Travis tests have failedHey mbrenguier, 1st Buildvendor/bin/phpcs --standard=./phpcs.xml ./Library/vendor/phpunit/phpunit/phpunit -c Tests/phpunit.xml |
Travis tests have failedHey mbrenguier, 1st Buildvendor/bin/phpcs --standard=./phpcs.xml ./Library/vendor/phpunit/phpunit/phpunit -c Tests/phpunit.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.