Port module to python3 - #4
Open
fim wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @fim, Thanks for the port to python3! However, I don't have time to maintain the module anymore. So, I don't think that merging your changes into the older module is really necessary. Regards, Vincent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've made an effort to port this module to python3. The work is not backwards compatible with Python2.X (mainly due to the deprecation of the cStringIO which would mean a lot of code duplication for supporting both versions) and is provided as-is.
I've tested the change and it seems to work as expected but any comments are welcome!