Skip to content

fix: consequence-based reviews and persistent follow-up context - #114

Merged
vsem-azamat merged 1 commit into
mainfrom
improve/review-convergence
Sep 5, 2026
Merged

vsem-azamat merged 1 commit into
mainfrom
improve/review-convergence

Conversation

@vsem-azamat

Copy link
Copy Markdown
Owner

Summary

  • Make blocking review findings consequence-based: require a concrete defect, governing requirement violation, or realistic material risk. Style preferences alone are advisory.
  • Carry the latest substantive changes-requested findings into follow-up reviews. Technical errors preserve context; approval clears it; task resets stay isolated.
  • Separate trusted follow-up instructions from untrusted finding data and explicitly describe the supplied diff as cumulative.
  • Prevent Deferred labels from automatically waiving defects in retained code; align canonical docs and generated distributions.

Verification

  • npm test: 817 tests, 813 passed, 4 skipped, 0 failed.
  • npm run check: exit 0 (14 warnings and 1 informational diagnostic; not warning-free).
  • npm run selfcheck: stdd check: OK.
  • git diff --check: passed.
  • Independent read-only review and follow-up: four findings addressed; no remaining material blockers. Review was conducted outside the STDD review runner.
  • Regression coverage includes unchanged-snapshot follow-up, changes-requested → error, approved → error without resurrection, task-reset isolation, and prompt trust boundaries.

Documentation evidence

Docs updated first: method/README.md, method/reference-commands.md, playbooks/planning.md

Scope and limitations

  • Verdict derivation, schema, gate behavior, round budget, and snapshot freshness contracts are unchanged.
  • Budget-exhaustion deadlock and its existing defer/proceed message remain a separate task.
  • No live reviewer-runner benchmark: fewer review rounds or token savings are not established by these tests.
  • Live runners were stubbed in regression tests. No package publication, deployment, or consumer installation.
  • Canonical method is close to its existing size ceiling; an unused import remains as a non-blocking lint warning in the reviewed candidate.

@vsem-azamat
vsem-azamat merged commit 06a96bc into main Sep 5, 2026
13 checks passed
@vsem-azamat
vsem-azamat deleted the improve/review-convergence branch September 5, 2026 09:40
vsem-azamat added a commit that referenced this pull request Sep 6, 2026
## Summary
Prepare `@stdd/cli` and `@stdd/plugin` 0.11.0 in a release-only PR.
- Align package/lock/plugin/runtime versions and regenerate all host
stamps and manifest hashes with existing hook targets preserved.
- Refresh README doctor proof and agent-context report version stamp;
retain historical baseline and measurements.
- No new runtime behavior in this PR.

## Included since 0.10.0
Merged changes cover intent-first instructions and consistent worktrees
(#113), consequence-based reviews and persistent follow-up context
(#114), consistent exhausted-budget guidance (#115), reduced mandatory
context and installed reference documents (#116).

## Verification
- Coordinator rerun `npm test`: 829 tests, 825 passed, 4 skipped, 0
failed.
- `npm run check`: exit 0, existing 14 warnings / 1 info.
- `npm run selfcheck`: OK; `git diff --check`: passed.
- Independent read-only release review: no material blockers; version,
manifest targets, runtime mirror and preserved measurement baseline
checked. Review conducted outside the STDD review runner.
- Implementer also exercised linux-x64 native workflow scenario, native
prebuild checks and npm package dry runs for CLI/plugin.
- Live model-backed contract harness not run; no publishing or consumer
installation performed.

Docs not applicable: release 0.11.0 version bump: generated stamps
regenerated per CONTRIBUTING Releases, no behavior change

## Upgrade and release boundary
After upgrading, consumers must re-run `stdd init` with their existing
tools/hook flags to receive `.stdd/reference/`. This PR does not update
any consumer project.

Merge this preparation PR before tagging. A separately authorized
`v0.11.0` tag on the merged commit triggers the repository release
workflow for npm packages and GitHub Release. No tag or publication has
been performed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant