Skip to content

feat: version linker flags#32

Merged
vshulcz merged 6 commits into
sprint_7from
iter23
Dec 16, 2025
Merged

feat: version linker flags#32
vshulcz merged 6 commits into
sprint_7from
iter23

Conversation

@vshulcz

@vshulcz vshulcz commented Dec 14, 2025

Copy link
Copy Markdown
Owner

No description provided.

@vshulcz vshulcz requested a review from Perederey December 14, 2025 21:01
@codecov

codecov Bot commented Dec 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.28736% with 325 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/reset/main.go 16.52% 94 Missing and 2 partials ⚠️
cmd/reset/logic.go 14.85% 83 Missing and 3 partials ⚠️
cmd/reset/helpers.go 47.82% 46 Missing and 2 partials ⚠️
cmd/staticlint/main.go 0.00% 39 Missing ⚠️
cmd/staticlint/osexitmain/osexitmain.go 22.85% 23 Missing and 4 partials ⚠️
pkg/util/common.go 0.00% 8 Missing ⚠️
cmd/reset/args.go 61.53% 3 Missing and 2 partials ⚠️
internal/adapters/publisher/httpjson/client.go 33.33% 2 Missing and 2 partials ⚠️
internal/misc/pool.go 76.47% 4 Missing ⚠️
cmd/agent/main.go 0.00% 3 Missing ⚠️
... and 2 more
Flag Coverage Δ
unittests 62.58% <25.28%> (-11.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/adapters/audit/file/writer.go 47.36% <ø> (ø)
internal/adapters/audit/remote/client.go 37.93% <ø> (ø)
internal/adapters/collector/runtime/runtime.go 93.42% <ø> (ø)
internal/adapters/persistence/file/file.go 71.42% <ø> (ø)
internal/adapters/repository/memory/memory.go 100.00% <ø> (ø)
internal/adapters/repository/postgres/postgres.go 91.33% <ø> (ø)
internal/services/agent/agent.go 97.36% <ø> (ø)
internal/services/metrics/metrics.go 91.79% <ø> (ø)
internal/adapters/http/ginserver/handler.go 88.15% <33.33%> (-0.51%) ⬇️
cmd/agent/main.go 0.00% <0.00%> (ø)
... and 10 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Perederey Perederey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Отличная работа!

Из того, на что стоит обратить внимание:

  • Дублирование кода: функции na() и printBuildInfo() повторяются в cmd/agent и cmd/server, лучше вынеси их в общий пакет
  • Файл cmd/reset/main.go слишком большой лучше разбей его на несколько файлов по ответственности
  • Избегай пакетов с именем "misc", лучше создавай более специфичные названия типа poolutil или syncutil

А так молодец! Код хорошо структурирован, добавлены тесты и документация. Продолжай в том же духе!

Comment thread internal/misc/pool.go
Comment thread cmd/staticlint/main.go Outdated
Comment thread internal/misc/pool.go
@vshulcz vshulcz merged commit 3b731f4 into sprint_7 Dec 16, 2025
5 of 6 checks passed
@vshulcz vshulcz deleted the iter23 branch December 16, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants