Repository navigation
fix(hermes): a session still in state.db-wal reaches recall, and a /branch's recall leaves out its source - #5142
Merged
Merged
Conversation
…ranch's recall leaves out its source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The walk fingerprinted a SQLite store by the db file alone. Hermes writes go to state.db-wal until a checkpoint, so new sessions never got indexed. It now counts the -wal's size and mtime too, in fields of its own: the reader-sidecar fields would send a thin-titled DB session through the whole-session re-read. /branch sessions are read as forks of
model_config._branched_from, and an unindexed branch is looked up by id in the sessions table so lineage leaves its source out.Tests: TestAStoreThatWroteOnlyItsWALReadsAsChanged, TestAHermesBranchsRecallLeavesOutItsSource (both fail before), TestAHermesBranchIsAForkOfItsSource. Branch rows indexed before this pick up the fork kind when they are re-read or on
deja index --rebuild; no index version bump.Closes #5140, Closes #5141