crash ucl_add_string_fuzzer.c by ensuring null-termination of strings#314
Open
Shivam7-1 wants to merge 1 commit intovstakhov:masterfrom
Open
crash ucl_add_string_fuzzer.c by ensuring null-termination of strings#314Shivam7-1 wants to merge 1 commit intovstakhov:masterfrom
Shivam7-1 wants to merge 1 commit intovstakhov:masterfrom
Conversation
Author
|
Hii @vstakhov Could you please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue link: https://issues.oss-fuzz.com/issues/376496309
In this PR now checks if the size is 0 or if the string is not null-terminated and appends a null-terminator which prevent crashes.