Problem with bindings of child classes being set on the parent class resulting in polluted bindings

[coolblades]

We have been using this for 3 months now, and like it so far - it is our intermediate step to go from ng1.5 to ng7.
We have create a base class with @input and many child classes off that and each child class has its own @input.
We started to see the instance of the child class contained many extra properties that are not part it.
I traced the code to what I have updated in my pull request:
The Reflection returns object back and it gets the meta of the child class's parent first, and it will find the parent class' binding object and returning that. And in ts-decorator it add a binding to the object returned (parent's object) and store back to itself. Since object is by reference, this mean the child and parent is sharing the same object. So my change is to clone the object returned (shallow) and add new binding to that and store the new object back.

I tested locally with our code and that solve the issues we were seeing.

I went ahead and update any of the decorators that is placed inside of a class. Please review it and see if it is ok.

Btw, I tried to build it with npm run install, but no luck. Not sure how you build it :)

Jonathan

[coveralls]

Coverage increased (+0.2%) to 69.257% when pulling b1b6057 on coolblades:master into 681ceec on vsternbach:master.

[coolblades]

hold on, I encountered an issue, going to try debug it.

[coolblades]

false alarm, error in our code we had binding name started with dataXXX and it got lost when it become data-xxx. Previously without ts-decorator, angular was more forgiving.

[MartijnWelker]

I actually ran into the same issuer over at #96 and came to the same fix in #97

[coolblades]

Martijn, great mind think a like :) I am glad we have the same solution, hopefully it will get merged.

[vsternbach]

Sorry, was a bit overloaded at work lately. Seems that @MartijnWelker solution is a bit more elegant, although it seems to be a bug there

[MartijnWelker]

@vsternbach I actually changed the fix I had in my pull request over at rentmanpublic@d58e488, if you want I can open a pull request with those changes.

[coolblades]

Just want to make sure the change can be used in IE11, not sure spread operator is valid for IE11, which we need to support.

[MartijnWelker]

@coolblades I assumed the typescript compilation process would take care of that, but it's a good idea to test that 👍

[vsternbach]

there's no any problem in using es6+ features since it's compiled to es5 anyway

[vsternbach]

Afaik from angular extending classes are not getting any of the inputs and outputs from the parent class, so I think I'll be changing that here as well, so each call to getMetadata will be replaced with getOwnMetadata, so this will be kind of braking change here, but then this code will be easier to port to angular
UPDATE: actually now I am not sure anymore what should be the behaviour: angular/angular@f5c8e09