fix(isVisible): treat <summary> in closed <details> as visible#2847
Closed
AhmadHannan037 wants to merge 1 commit into
Closed
fix(isVisible): treat <summary> in closed <details> as visible#2847AhmadHannan037 wants to merge 1 commit into
AhmadHannan037 wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thanks for the PR, but we already have one opened to solve the same issue in #2806 that we are going to prioritize. |
Contributor
Author
Going to close this since #2806 is already addressing the issue and is further along in review. Happy to help review there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2626.
isVisible() previously returned false for
<summary>(and<details>itself) when the parent<details>had no open attribute, even though the browser renders both. The check now mirrors HTML semantics: only non-<details>are hidden.<details>(open or closed) → visible<summary>(direct child) → visibleOther descendants → visible only when open
Tests added in tests/isVisible.spec.ts covering the open, closed, and nested-non-summary cases.