Add since and pagination to get_vendor_product_vulnerabilities()#77
Conversation
|
Thank you for the PR! I'll need to play a bit with it, but I think it wound be better to stop when the length of the response is to the limit, I fear the request as it is could fail is weird ways. |
|
Something like that ? Length of the response could be calculated in a reduce one-liner, but I'm not sure if it would help readability. |
|
Hi, I saw some tests failed (seems redis) and some others infinitely looped. It does not seem related to my code, when I launch tests on my side on the changed function it looks ok. Just to be sure, are u expecting something from me ? Cheers |
|
Sorry, I completely forgot about this one. I'm merging it now but a bit differently, as I just added iterators on other endpoints, and I'm trying to keep it consistent. |
|
Great ! Thank you ! |
Hi,
This PR adds :
sinceparameter, exposed by the API, to the python binding;I'm not very confident in the while condition to detect that we got all results, maybe another test would fit better ?
Cheers,
François