Skip to content

chore: remove deployment scripts and CI workflows - #20

Merged
johnnyluo merged 3 commits into
mainfrom
chore/remove-deployment-scripts
Apr 5, 2026
Merged

chore: remove deployment scripts and CI workflows#20
johnnyluo merged 3 commits into
mainfrom
chore/remove-deployment-scripts

Conversation

@johnnyluo

@johnnyluo johnnyluo commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove all Kubernetes manifests under deploy/ (server, worker, dev/prod configs, ingress)
  • Remove all deployment-related GitHub Actions workflows (deploy-dev, deploy, build-push-image, sync-main-to-dev)

Deployments will be handled manually going forward.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed deployment automation workflows for development and production environments.
    • Removed notification server and worker service configurations.
    • Removed all associated Kubernetes manifests and infrastructure-as-code definitions for staging and production deployments.

Remove all deploy/ Kubernetes manifests and deployment-related GitHub
Actions workflows (build-push-image, deploy-dev, deploy, sync-main-to-dev).
Deployments will be handled manually going forward.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e9745d96-22ad-4d16-94e3-6281c3339d76

📥 Commits

Reviewing files that changed from the base of the PR and between 1dd2378 and 69d33f8.

📒 Files selected for processing (10)
  • .github/workflows/build-push-image.yaml
  • .github/workflows/deploy-dev.yaml
  • .github/workflows/deploy.yaml
  • .github/workflows/sync-main-to-dev.yaml
  • deploy/01_server.yaml
  • deploy/01_worker.yaml
  • deploy/dev/01_notification.yaml
  • deploy/dev/02_ingress.yaml
  • deploy/prod/01_notification.yaml
  • deploy/prod/02_ingress.yaml
💤 Files with no reviewable changes (10)
  • .github/workflows/sync-main-to-dev.yaml
  • deploy/prod/01_notification.yaml
  • deploy/dev/01_notification.yaml
  • deploy/dev/02_ingress.yaml
  • deploy/prod/02_ingress.yaml
  • .github/workflows/build-push-image.yaml
  • deploy/01_worker.yaml
  • deploy/01_server.yaml
  • .github/workflows/deploy.yaml
  • .github/workflows/deploy-dev.yaml

Walkthrough

This pull request removes GitHub Actions workflows for building, pushing, and deploying Docker images alongside Kubernetes configuration files for notification service components in development and production environments.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build-push-image.yaml, .github/workflows/deploy-dev.yaml, .github/workflows/deploy.yaml, .github/workflows/sync-main-to-dev.yaml
Removed reusable Docker build-push workflow and three deployment workflows that handled image building, Kubernetes manifest updates, and rollout orchestration for dev and prod environments. Also removed CI workflow syncing main to dev branch.
Kubernetes Base Deployments
deploy/01_server.yaml, deploy/01_worker.yaml
Removed Kubernetes Service and Deployment resources for notification-server and notification-worker, including container configurations, environment variables from ConfigMaps/Secrets, volume mounts for certificates, and health probes.
Kubernetes Dev Environment
deploy/dev/01_notification.yaml, deploy/dev/02_ingress.yaml
Removed dev ConfigMap providing runtime configuration (server host/port, VAPID keys, certificate paths) and Ingress resource routing HTTPS traffic to notification-server via Traefik and cert-manager.
Kubernetes Prod Environment
deploy/prod/01_notification.yaml, deploy/prod/02_ingress.yaml
Removed prod ConfigMap and Ingress resource mirroring the dev environment configuration for production deployment of the notification service.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main changes: removal of deployment scripts (Kubernetes manifests) and CI workflows (GitHub Actions files).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-deployment-scripts

Comment @coderabbitai help to get the list of available commands and usage tips.

@johnnyluo
johnnyluo merged commit 9684a06 into main Apr 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants