Skip to content

[Stride] Ensure default value for unknown shader types in ParameterPinDescription #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tebjan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Stride] Ensure default value for unknown shader types in ParameterPinDescription #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions VL.Stride.Runtime/src/Rendering/Effects/EffectShaderNodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,14 @@ private static ParameterPinDescription CreatePinDescription(ParameterKey key, in
if (isOptionalOverride.HasValue)
isOptional |= isOptionalOverride.Value;

// Ensure unknown shader types always get a valid default value for the pin
if (typeInPatch == typeof(IComputeNode) && runtimeDefaultValue == null && key.PropertyType == typeof(Stride.Shaders.ShaderSource))
{
// Use the variable name as the type name for the fallback
var typeName = key.GetVariableName();
runtimeDefaultValue = new VL.Stride.Rendering.CompositionInput.ShaderSourceComputeNode(new Stride.Shaders.ShaderClassSource(typeName));
}

return new ParameterPinDescription(usedNames, key, count,
compilationDefaultValue: compilationDefaultValue,
name: name,
Expand Down