fix(viz): render braille visualisers edge-to-edge#55
Merged
Conversation
Pulse grows its disc against the longer half-axis so it fills the pane on wide terminals instead of hugging the middle with black gutters. Scope is intrinsically square (Lissajous in signal space), so it letterboxes with a muted phosphor-green gutter rather than stretching. Wave, Heartbeat, and BarsDot now paint empty cells with their palette's muted backdrop colour instead of raw black, so the pane reads as "the viz chose this shape" rather than "the viz is broken". Each touched visualiser gains a 120x40 render test asserting that every edge row and column carries either a painted dot or a palette-tinted cell. Closes clitunes-ciy / CLI-87
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Slice 1 (#54) removed the outer 1-col / 2-row pane inset so the cell grid stretches to the full pane. This slice fixes the remaining within-grid emptiness: braille visualisers that painted small centred shapes with large pure-black gutters around them. The pane now reads as "the viz chose this shape" rather than "the viz is broken" across the whole braille family.
The rewrite temptation for Scope was resisted — its Lissajous curve is inherently square, so it letterboxes with a muted phosphor tint instead of being stretched into an oval. Other geometrically-uniform viz (metaballs, terrain, retro, sakura, firework, scatter, butterfly, rain, binary, moire, tunnel, vortex, plasma, ripples, fire, matrix, bars_outline, classic_peak, density_ramp) already cover the full pane and were left untouched.
Test plan