fix(release): strip -rcN suffix when extracting CHANGELOG notes#66
Merged
Conversation
RCs share release notes with their target version, so the awk lookup should match ## [X.Y.Z] even when the tag is vX.Y.Z-rcN. Removes the need to maintain throwaway ## [X.Y.Z-rcN] stanzas (the old convention, which caused v1.2.1-rc1 to fail). Caught by the v1.2.1-rc1 dry run failing at the release step while all 4 builds + the RC tap-bump-skip behaved correctly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line awk fix: RCs now share release notes with their target version.
v1.2.1-rc1matches## [1.2.1]in CHANGELOG.md instead of the non-existent## [1.2.1-rc1].Why
Caught by the
v1.2.1-rc1dry-run for v1.2.1:releasestep failed — `release-notes.md is empty — CHANGELOG.md has no [1.2.1-rc1] section`homebrew-tapcorrectly skipped via `-rc` guardPrior convention required a per-RC `## [1.2.1-rc1]` CHANGELOG stanza (see PR #52 for v1.1.0-rc1). That's wasteful: RCs and their real release describe the same thing. Stripping the suffix means we stop maintaining throwaway stanzas forever.
Behavior
v1.2.1-rc1→BASE_VERSION=1.2.1→ extracts## [1.2.1]section.v1.2.1→BASE_VERSION=1.2.1→ extracts## [1.2.1]section (unchanged).v2.0.0-rc3→BASE_VERSION=2.0.0→ extracts## [2.0.0]section.Follow-up tag plan
After this merges: cut
v1.2.1-rc2to re-validate. Expect 5 green jobs + tap-bump skipped. Then cut realv1.2.1.Test plan
v1.2.1-rc2release.yml run completes green through the release step