Feat: Version 16 changes.#6
Open
varun-krishnamurthy wants to merge 23 commits into
Open
Conversation
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
- Extend apps.json to support "source" field for local app directories, allowing S2I builds to copy apps from checked-out submodules instead of cloning from git (no credentials needed during build) - Install new apps on existing site when layering on top of an SNE image - Add central-site Makefile targets using ERPNext SNE as the builder image Made-with: Cursor
When building on top of an existing SNE image (DB already initialized), use mysqld directly instead of run-mysqld (SCL init wrapper conflicts with pre-secured DB). Also fix wait_for_mariadb to try auth credentials before unauthenticated ping, with a timeout to avoid infinite loops. Made-with: Cursor
When building via s2i-podman.sh, copy the repo's s2i/bin/ scripts into the build context and inject a COPY before the RUN assemble step. This ensures the build uses the repo's current assemble/run scripts rather than the ones baked into the builder image, enabling iteration without rebuilding the base image. Made-with: Cursor
Under QEMU emulation (arm64 builds), a stale mysqld can occupy port 3306 causing "Address already in use" errors. Made-with: Cursor
- Detect QEMU emulation in Redis startup (assemble + run) and surface a clear error message instead of a cryptic segfault - Add ENABLE_ASSETS_CACHE feature flag to persist built assets across volume mounts (disabled by default) Made-with: Cursor
Runs after build-and-test to verify the pushed SNE image works: - Multi-arch manifest has both amd64 and arm64 entries - MariaDB, Redis, and bench all start successfully - Bench serves HTTP requests on port 8000 - Dumps logs on failure for debugging Made-with: Cursor
Disable Redis persistence in the S2I assemble/run flow and remove stale dump files so cached HTML does not reference outdated hashed assets. Clear Frappe cache after site setup and on startup to keep rendered pages aligned with the built dist bundles. Made-with: Cursor
Match the smoke test to the actual SNE runtime by checking MariaDB, Redis, and the esbuild watch process instead of requiring gunicorn. The HTTP ping check already verifies the web process is serving requests. Made-with: Cursor
Run browser-level checks against /login and authenticated /desk to fail on any non-200 /assets/* requests or frontend runtime errors. This verifies the exact asset URLs sent to developers' browsers, not just files on disk. Made-with: Cursor
Relocate the Cypress asset integrity suite from test/ to a dedicated e2e_test/ folder and update the CI workflow to install and run it from the new path. Made-with: Cursor
Allow workflow_dispatch to accept an image_ref and run the SNE integrity checks without rebuilding. This manual path pulls the requested image, boots it, verifies core services, and runs the Cypress asset-integrity checks against /login and /desk. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.