Fix ARM64 container builds and local Docker support#8
Merged
varun-krishnamurthy merged 9 commits intoJun 7, 2026
Merged
Conversation
Compile Redis from source, pin frappe-bench, pre-install esbuild for aarch64, and resolve Containerfile build warnings so Apple Silicon builds succeed with make build-arm64 via podman or docker. Co-authored-by: Cursor <cursoragent@cursor.com>
…y test image in CI
- Add ARG TARGETARCH for arch-specific cache IDs in Containerfile - Cache Redis compilation via --mount=type=cache - Cache pip and npm downloads during bench init - Update Makefile to pass --build-arg TARGETARCH to all build targets - Implement S2I incremental caching in save-artifacts and assemble - Fix GitHub workflow Podman build cache paths and key strategy - Add .actrc for local act testing with catthehacker Ubuntu runner - Expand .gitignore to exclude .secrets, .DS_Store, scratch files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_ROOT, nginx env ordering, amd64-only base image)ContainerfileTest plan
make build-arm64 FRAPPE_VERSION=version-16on Apple SiliconInvalidBaseImagePlatform/UndefinedVarMade with Cursor