Skip to content

Fix duplicate port rendering when PortType.both is used #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
campcoxconsultants wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate port rendering when PortType.both is used #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/vyuh_node_flow/lib/src/editor/node_flow_editor_widget_handlers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,8 @@ extension _WidgetGestureHandlers<T, C> on _NodeFlowEditorState<T, C> {
if (node == null) return;

// Find the port
final port = [
...node.inputPorts,
...node.outputPorts,
].where((p) => p.id == portId).firstOrNull;
// Use node.ports directly to avoid duplicates when port has PortType.both
final port = node.ports.where((p) => p.id == portId).firstOrNull;
if (port == null) return;

widget.controller.events.port?.onContextMenu?.call(
Expand Down
18 changes: 5 additions & 13 deletions packages/vyuh_node_flow/lib/src/nodes/node_container.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,11 @@ class NodeContainer<T> extends StatelessWidget {
),
),

// Input ports (only when LOD allows and ports exist)
// Use port.isOutput to respect PortType (input, output, both)
// rather than list membership
if (lodVisibility.showPorts && node.inputPorts.isNotEmpty)
...node.inputPorts.map(
(port) => _buildPort(context, port, port.isOutput),
),

// Output ports (only when LOD allows and ports exist)
// Use port.isOutput to respect PortType (input, output, both)
// rather than list membership
if (lodVisibility.showPorts && node.outputPorts.isNotEmpty)
...node.outputPorts.map(
// Ports (only when LOD allows and ports exist)
// Iterate over all ports directly to avoid duplicate rendering
// when a port has PortType.both (would appear in both inputPorts and outputPorts)
if (lodVisibility.showPorts && node.ports.isNotEmpty)
...node.ports.map(
(port) => _buildPort(context, port, port.isOutput),
),

Expand Down