Repository navigation
fix: make the Marketplace publish step reachable - #10
Merged
Merged
Conversation
The publish step guarded on `env.VSCE_PAT` while defining VSCE_PAT in its own `env:` block. A step's `env:` is not in scope for that same step's `if:`, so the condition read an undefined value and was always false: tagging a release built and attached the .vsix, reported success, and never published. Move the secret to job scope so the guard sees it, and emit a warning on the skip path — a silent skip is indistinguishable from a successful publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow could never publish.
A step's
env:block is not in scope for that same step'sif:. The conditionread an undefined value, so it was always false. Tagging a release would build,
test, package, attach the
.vsix, go green — and silently never reach theMarketplace, even with the secret set correctly.
VSCE_PATto job scope so the guard can see it.identical to "published".
Verified locally on this commit:
npm ci,npm run compile,npm run test:unit(14 passing), and
vsce package-> 217 KB, 73 files,out/extension.jspresent.Both workflows still parse.