Repository navigation
feat: install on Windows, and publish where people actually install from - #12
Merged
Merged
Conversation
Three reasons a person could not install this extension: - **Windows.** `downloadRelease` threw "Windows auto-download is not available yet". That was true, but only because no leg of the core release ever built a Windows archive — nothing in the code needed it. labwired-core now builds x86_64-pc-windows-msvc, so the platform table gets its entry. `tar` ships with Windows 10 and later and binaryName() already appends the .exe, so nothing else changes. - **Open VSX.** VSCodium, Cursor, Windsurf and the Theia editors do not install from the Microsoft Marketplace at all. The release now publishes to both registries, and says explicitly which one a tag failed to reach — a silent skip reads exactly like a successful publish. - **The pin.** CLI_VERSION sat at v0.19.3 while core released v0.21.0. Debugging shipped against a CLI that predated half the boards in the docs. Now v0.22.0. PLATFORM_ASSETS moves into src/platformAssets.ts so it can be unit-tested without a VS Code host: this one table decides whether the extension can install the simulator at all, and it lost Windows for months with no test that could notice. 26 unit tests, tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three separate reasons someone could not install this extension.
1. It is on neither registry.
marketplace.visualstudio.com/items?itemName=w1ne.labwired-vscode→ 404,open-vsx.org/api/w1ne/labwired-vscode→ 404. The only install path is the.vsixattached to v0.14.0, which has 0 downloads. The release workflow now publishes to Open VSX as well — that is where VSCodium, Cursor, Windsurf and the Theia editors install from — and reports which registry a tag failed to reach instead of skipping in silence.2. Windows.
downloadReleasethrewWindows auto-download is not available yet. Nothing in the extension needed that:tarships with Windows 10 and later, andbinaryName()already appends.exe. The real gap was that no leg of the core release built a Windows archive. labwired-core#964 addsx86_64-pc-windows-msvc— a dispatch dry-run of that workflow built it green — so this adds the platform-table entry.3. The pin.
CLI_VERSIONwasv0.19.3while core had releasedv0.21.0. F5 ran against a CLI that predated half the boards in the docs. Nowv0.22.0.PLATFORM_ASSETSmoves intosrc/platformAssets.tsso it can be unit-tested without a VS Code host. That one table decides whether the extension can install the simulator at all, and it silently lacked Windows for months because no test could reach it.Merge order
After core v0.22.0 is tagged. The pin and the Windows asset both point at that release; merging earlier leaves the extension asking for archives that do not exist yet.
Still needs you
Publishing stays a warning until the credentials exist:
VSCE_PAT— create thew1nepublisher at marketplace.visualstudio.com/manage, then an Azure DevOps PAT scoped to Marketplace → Manage.OVSX_PAT— create a namespace at open-vsx.org and an access token.Add both as repository secrets. Until then a tag still attaches the
.vsix, and the run says out loud which registries it did not reach.Verification
26 unit tests (4 new, covering the platform table),
tsc -p . --noEmitclean,actionlintclean on the release workflow.