Repository navigation
feat: report extension failures instead of only showing them - #13
Merged
Merged
Conversation
The playground and the CLI both report failures now. The editor was the last surface where a failure reached only the person it happened to — and its failures are the ones a user is least able to describe: the Run button did nothing, F5 did nothing, and the output channel scrolled past the reason. Both binary-resolution paths now report before re-throwing: F5's DAP lookup and the Run button's CLI lookup. Those are where a broken release actually lands in this extension. What leaves the machine is the same enumerated row the installer sends — surface, stage, platform, release, channel, an allowlisted error class and a fingerprint. Never the message: in an editor extension the message is the user's workspace path or their firmware's name. The fingerprint is FNV-1a over the error type and its first stack frame's function name; paths never enter it. `host_class` carries where the binary came from — bundled, PATH, downloaded — which is the field that separates "our release is broken" from "their PATH has something else on it". VS Code's own telemetry switch governs this: if it is off, nothing is sent, without asking again in our own setting. `labwired.telemetry.enabled` is the separate off switch for people who leave editor telemetry on. The pure parts live in crashFingerprint.ts so they can be unit-tested without a VS Code host — `import * as vscode` cannot load in plain mocha, and a fingerprint function nobody can test is one nobody should trust with "never put a path in this". 29 unit tests, tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playground and the CLI both report failures now. The editor was the last surface where a failure reached only the person it happened to — and its failures are the ones a user is least able to describe: the Run button did nothing, F5 did nothing, the output channel scrolled past the reason.
Both binary-resolution paths report before re-throwing — F5's DAP lookup and the Run button's CLI lookup. That is where a broken release actually lands in this extension.
What leaves the machine is the same enumerated row the installer sends: surface, stage, platform, release, channel, an allowlisted error class, and a fingerprint. Never the message — in an editor extension the message is the user's workspace path or their firmware's name. The fingerprint is FNV-1a over the error type and its first stack frame's function name; paths never enter it.
host_classcarries where the binary came from (bundled / PATH / downloaded), which is the field that separates "our release is broken" from "their PATH has something else on it".Consent: VS Code's own telemetry switch governs this — if it is off, nothing is sent, without asking again in our own setting.
labwired.telemetry.enabledis the separate off switch for people who leave editor telemetry on.The pure parts live in
crashFingerprint.tsso they can be unit-tested without a VS Code host:import * as vscodecannot load in plain mocha, and a fingerprint function nobody can test is one nobody should trust with "never put a path in this".29 unit tests,
tsc -p . --noEmitclean.