Skip to content

Add AlignmentTSO#107

Open
PauenN wants to merge 4 commits into
w3c-lbd-cg:masterfrom
PauenN:master
Open

Add AlignmentTSO#107
PauenN wants to merge 4 commits into
w3c-lbd-cg:masterfrom
PauenN:master

Conversation

@PauenN
Copy link
Copy Markdown

@PauenN PauenN commented Mar 12, 2021

Add the proposed alignment from BOT v0.3.2 to TSO v0.2 as discussed at the LBD CG Call February 23.

@GeorgFerdinandSchneider
Copy link
Copy Markdown
Collaborator

Dear @PauenN ,

thank you for submitting the proposed alignments. I have some minor sugesstions for improvement. If they are fixed I am fine to merge the proposed BOT-to-TSO-Alignment:

  • Please rename the file to TSOAlignment; this is a convention for alignment files
  • Please issue a version as of semver.org: v0.2.0
  • Please add a version IRI for the Alignment, i.e. owl:versionIRI <THE_IRI> ;

Thank you

@mathib feel free to merge when changes have been made

@PauenN
Copy link
Copy Markdown
Author

PauenN commented Jun 1, 2021

Dear @GeorgFerdinandSchneider ,

I added your suggested improvements as well as a new alignment for an object property. Could you please check the added alignment before merging.

Thanks, Nico

@mathib
Copy link
Copy Markdown
Member

mathib commented Jun 1, 2021

looks good to me. I see there's also a small addition in the alignment:
tso:contains rdfs:subPropertyOf bot:hasElement .

I'll give some time to @GeorgFerdinandSchneider to check it :)

@PauenN
Copy link
Copy Markdown
Author

PauenN commented Jun 9, 2021

@GeorgFerdinandSchneider @mathib I changed the alignment from tso:System rdfs:subClassOf bot:Element to tso:Component rdfs:subClassOf bot:Element. Please take this into consideration while reviewing the alignment. Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants