Add confidence field to PerformanceNavigationTiming#210
Merged
yoavweiss merged 1 commit intow3c:gh-pagesfrom Dec 5, 2025
Merged
Add confidence field to PerformanceNavigationTiming#210yoavweiss merged 1 commit intow3c:gh-pagesfrom
confidence field to PerformanceNavigationTiming#210yoavweiss merged 1 commit intow3c:gh-pagesfrom
Conversation
yoavweiss
reviewed
Nov 19, 2025
f4e8af8 to
b2dda1a
Compare
Contributor
|
Thanks! This looks significantly better. I think we can now add a note telling developers what the debiasing process of theeir metrics should be. |
Contributor
Author
Thanks for the review. I've added this note. PTAL. |
yoavweiss
reviewed
Dec 2, 2025
confidence field to PerformanceNavigationTiming
yoavweiss
reviewed
Dec 3, 2025
Contributor
yoavweiss
left a comment
There was a problem hiding this comment.
Looks great! A couple of final nits
d3ddd06 to
4a33f39
Compare
4a33f39 to
4471389
Compare
yoavweiss
approved these changes
Dec 5, 2025
Contributor
yoavweiss
left a comment
There was a problem hiding this comment.
LGTM! Thanks for pushing this through!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
confidenceas a new attribute of PerformanceNavigationTimingPreview | Diff