Skip to content

Add 'attribute' keyword to IDL attribute dfns for Bikeshed #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoavweiss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 'attribute' keyword to IDL attribute dfns for Bikeshed #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ A {{PerformanceNavigationTiming}} has an associated null or [=service worker tim
<dfn data-dfn-for="PerformanceNavigationTiming">service worker timing</dfn>.

<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>unloadEventStart</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>unloadEventStart</dfn> getter steps are to return |this|'s
[=previous document unload timing=]'s [=document unload timing info/unload event start
time=].
<p class="note">If the previous document and the current document have the same
Expand All @@ -384,7 +384,7 @@ A {{PerformanceNavigationTiming}} has an associated null or [=service worker tim
zero.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>unloadEventEnd</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>unloadEventEnd</dfn> getter steps are to return |this|'s
[=previous document unload timing=]'s
[=document unload timing info/unload event end time=].
<p class="note">If the previous document and the current document have the same
Expand All @@ -396,68 +396,68 @@ A {{PerformanceNavigationTiming}} has an associated null or [=service worker tim
zero.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>domInteractive</dfn> getter steps are to return
The <dfn attribute data-export>domInteractive</dfn> getter steps are to return
|this|'s [=document load timing=]'s [=document load timing info/DOM interactive time=].</p>

<p class="note">This timestamp is measured before the user agent sets the
[=current document readiness=] to
[=the end|"interactive"=].
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>domContentLoadedEventStart</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>domContentLoadedEventStart</dfn> getter steps are to return |this|'s
[=document load timing=]'s
[=document load timing info/DOM content loaded event start time=].</p>
<p class="note">This timestamp is measured before the user agent dispatches the
[=DOMContentLoaded=]
event.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>domContentLoadedEventEnd</dfn> getter steps are to return
The <dfn attribute data-export>domContentLoadedEventEnd</dfn> getter steps are to return
|this|'s [=document load timing=]'s
[=document load timing info/DOM content loaded event end time=].</p>
<p class="note">This timestamp is measured after the user agent completes handling of the
[=DOMContentLoaded=]
event.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>domComplete</dfn> getter steps are to return
The <dfn attribute data-export>domComplete</dfn> getter steps are to return
|this|'s [=document load timing=]'s [=document load timing info/DOM complete time=].
<p class="note">This timestamp is measured before the user agent sets the
[=current document readiness=] to
[=the end|"complete"=]. See [=current document readiness|document readiness=] for a precise
definition.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>loadEventStart</dfn> getter steps are to return
The <dfn attribute data-export>loadEventStart</dfn> getter steps are to return
|this|'s [=document load timing=]'s [=document load timing info/load event start time=].</p>
<p class="note">This timestamp is measured before the user agent dispatches the
<a href="https://html.spec.whatwg.org/multipage/indices.html#event-load">load</a> event for the document.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>loadEventEnd</dfn> getter steps are to return
The <dfn attribute data-export>loadEventEnd</dfn> getter steps are to return
|this|'s [=document load timing=]'s [=document load timing info/load event end time=].</p>
<p class="note">This timestamp is measured after the user agent completes handling the
<a href="https://html.spec.whatwg.org/multipage/indices.html#event-load">load</a> event for the document.
</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn>type</dfn> getter steps are to run the |this|'s [=navigation type=].
The <dfn attribute>type</dfn> getter steps are to run the |this|'s [=navigation type=].
</p>
<div class="note">
<p>
Client-side redirects, such as those using the [=Refresh pragma directive|Refresh pragma
directive=], are not considered [=redirect status|HTTP redirects=] by this spec. In those
cases, the <a for="PerformanceNavigationTiming">type</a>
cases, the {{PerformanceNavigationTiming/type}}
attribute SHOULD return appropriate value, such as
<a for="NavigationTimingType">reload</a> if reloading the
current page, or <a for="NavigationTimingType">navigate</a> if
navigating to a new URL.
</p>
</div>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>redirectCount</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>redirectCount</dfn> getter steps are to return |this|'s
<span>redirect count</span>.</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>criticalCHRestart</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>criticalCHRestart</dfn> getter steps are to return |this|'s
<span>`Critical-CH` restart time</span>.</p>
<div class="note">
<p>
Expand All @@ -467,10 +467,10 @@ A {{PerformanceNavigationTiming}} has an associated null or [=service worker tim
</p>
</div>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>notRestoredReasons</dfn> getter steps are to return |this|'s
The <dfn attribute data-export>notRestoredReasons</dfn> getter steps are to return |this|'s
<span>not restored reasons</span>.</p>
<p data-dfn-for='PerformanceNavigationTiming'>
The <dfn data-export>confidence</dfn> getter steps are to run these steps:
The <dfn attribute data-export>confidence</dfn> getter steps are to run these steps:
<ol>
<li>If |this|'s [=document load timing=]'s
[=document load timing info/DOM interactive time=] is 0, return null.</li>
Expand Down Expand Up @@ -631,7 +631,7 @@ interface PerformanceTimingConfidence {
</pre>
<dl data-dfn-for='PerformanceTimingConfidence'>
<dt>
<dfn data-export>randomizedTriggerRate</dfn>
<dfn attribute data-export>randomizedTriggerRate</dfn>
</dt>
<dd>
<p>
Expand All @@ -641,7 +641,7 @@ interface PerformanceTimingConfidence {
</p>
</dd>
<dt>
<dfn data-export>value</dfn>
<dfn attribute data-export>value</dfn>
</dt>
<dd>
<p>
Expand Down
Loading