Embed the markdown template into the main questionnaire.#191
Merged
Conversation
jyasskin
commented
Apr 14, 2025
Comment on lines
+1334
to
+1337
| <pre class=include-code> | ||
| path: questionnaire.markdown | ||
| highlight: markdown | ||
| </pre> |
Member
Author
There was a problem hiding this comment.
I could include just a subset of the lines, if the file's introductory text doesn't seem useful to embed... What do folks think?
Suggested change
| <pre class=include-code> | |
| path: questionnaire.markdown | |
| highlight: markdown | |
| </pre> | |
| <pre class=include-code> | |
| path: questionnaire.markdown | |
| highlight: markdown | |
| show: 9-9999 | |
| </pre> |
tantek
approved these changes
Apr 19, 2025
Contributor
tantek
left a comment
tantek
left a comment
There was a problem hiding this comment.
Good idea. For whether to include introductory text or not, I would suggest not including anything that you wouldn’t want by default left in the finished use of this template. Users of the template won't know (or think) to remove the introductory text, if that is in fact the intent.
Member
Author
|
Ping @pes10k @simoneonofri. |
simoneonofri
approved these changes
May 9, 2025
Contributor
|
lgtm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@miketaylr reported that this change would have prevented him from missing the existence of the markdown file. I don't have a strong opinion about the ordering relative to the Acknowledgements section or whether to call it a "Markdown Template" or something else.
Preview | Diff