Skip to content

fix(build): use network requests as well to find subresources#224

Merged
sidvishnoi merged 4 commits into
mainfrom
subresources-method
Feb 26, 2026
Merged

fix(build): use network requests as well to find subresources#224
sidvishnoi merged 4 commits into
mainfrom
subresources-method

Conversation

@deniak

@deniak deniak commented Feb 26, 2026

Copy link
Copy Markdown
Member

The last version of subresources provides a way to find the list of sub-resources based on network requests.
That PR adds an option to select that method


Preview | Diff

@deniak deniak requested a review from sidvishnoi February 26, 2026 08:09
Comment thread src/build.ts Outdated
@sidvishnoi

Copy link
Copy Markdown
Member

@deniak Can you verify all sub-resources are found (ref: sidvishnoi/subresources#8) by using uses: w3c/spec-prod@subresources-method in a PR where it failed?

@sidvishnoi sidvishnoi changed the title add option to select the subresources method. By default use 'dom'. fix(build): use network requests as well to find subresources Feb 26, 2026
Comment thread package.json
@deniak

deniak commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

@deniak Can you verify all sub-resources are found (ref: sidvishnoi/subresources#8) by using uses: w3c/spec-prod@subresources-method in a PR where it failed?

I just made a test from a fork and the action successfully fetch the font this time:
https://github.com/deniak/csswg-drafts/tree/gh-pages/css-color-5/images/fonts

@sidvishnoi sidvishnoi merged commit 492c953 into main Feb 26, 2026
1 check passed
@sidvishnoi sidvishnoi deleted the subresources-method branch February 26, 2026 10:49
@deniak

deniak commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

@sidvishnoi thanks!

@sidvishnoi

Copy link
Copy Markdown
Member

Released in v2.12.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants