Skip to content

fix(setup/bikeshed): ensure to use python3 with pipx#234

Closed
devincabillo-web wants to merge 2 commits into
w3c:mainfrom
devincabillo-web:devincabillo-web-patch-2
Closed

fix(setup/bikeshed): ensure to use python3 with pipx#234
devincabillo-web wants to merge 2 commits into
w3c:mainfrom
devincabillo-web:devincabillo-web-patch-2

Conversation

@devincabillo-web

Copy link
Copy Markdown
Contributor

The default ubuntu-latest runner uses an older Python version, causing pipx install 'bikeshed==7.*' to fail.

The default `ubuntu-latest` runner uses an older Python version, causing `pipx install 'bikeshed==7.*'` to fail.
Update tool chain setup to use python version compatible with bikeshed=7.

@sidvishnoi sidvishnoi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make this change in src/setup.ts instead? We can pass required env vars when running particular sh commands, or use process.env.PIPX_DEFAULT_PYTHON = 'python3' in that has to be done on multiple commands.
I'm asking this change to keep env vars as localized as possible.

Also, can you ensure this is working correctly in the repo it failed? You can create a test PR (or use on some existing one) like this to test:

- - uses: w3c/spec-prod@v2
+ - uses: devincabillo-web/spec-prod@devincabillo-web-patch-2

@sidvishnoi sidvishnoi changed the title Update actions.yml for env to use compatible python for bikeshed fix(setup/bikeshed): ensure to use python3 with pipx May 20, 2026
@devincabillo-web

Copy link
Copy Markdown
Contributor Author

@sidvishnoi I got the tests to pass with my local branch and opened a new PR here: #235

@sidvishnoi

Copy link
Copy Markdown
Member

Superseded by #235.

@sidvishnoi sidvishnoi closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants