This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Remove assert_object_equals.#143
Open
sideshowbarker wants to merge 1 commit into
Open
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/5727 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Member
Author
|
Need to wait for web-platform-tests/wpt#2033 to be resolved before merging this. |
|
I've found assert_object_equals useful several times, for example:
Sometimes you do need to compare two object hierarchies, and it seems unwise to expect people to re-invent the wheel each time. How about fixing it instead, for example #144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See See web-platform-tests/wpt#2030 and https://critic.hoppipolla.co.uk/showcomment?chain=12186
This change is