Enable createParserOptions, passing a sanitizer to trusted types by noamr · Pull Request #606 · w3c/trusted-types

noamr · 2026-02-17T11:13:22Z

createParserOptions receives a SetHTML{Unsafe}Options and turns them into a TrustedParserOptions using the given method from the policy config.

This is the trusted-types part of #594

Note that this should only be merged when wired into the HTML standard, once the sanitizer is itself upstreamed.

Preview | Diff

lukewarlow · 2026-02-17T15:04:50Z

LGTM

noamr · 2026-06-01T13:47:13Z

I've made some changes:

Some of the algorithm calls from "get Trusted Type compliant parser options" assumed stringifications. Made that algorithm do things on its own and passing a new object (repersented as an ordered map) instead.
Allow passing throwIfMissing from the outside. streamHTMLUnsafe methods should throw if the policy cannot create parser options, while setHTMLUnsafe and friends can rely on createHTML.
Support runScripts as per Add runScripts to SetHTMLUnsafeOptions whatwg/html#12495

(Note: this PR will fail build until we merge the latter)

lukewarlow · 2026-06-09T11:55:45Z

Are you able to fix the build failure now?

noamr · 2026-06-09T15:44:18Z

Are you able to fix the build failure now?

I'll revisit this once I have the HTML counterpart ready.

annevk · 2026-06-22T06:42:40Z


+## Get Trusted Type parser input ## {#get-trusted-type-parser-input-algorithm}
+
+To <dfn export>get Trusted Type compliant input</dfn> given a {{TrustedType}} |expectedType|, a [=realm/global object=] (|global|), string, or <code data-x="">Stream</code> |input|,


What is Stream?

It's a special value meaning that we don't have a string yet and we are going to stream the HTML. is null better? This seemed more descriptive.

annevk · 2026-06-22T06:47:13Z

+
+    1. Throw a TypeError and abort further steps.
+1. Let |sanitizer| be |policyValue|["`sanitizer`"], [=with default|defaulting to=] a new {{SanitizerConfig}}.
+1. If |sanitizer| is a {{Sanitizer}}, then set |sanitizer| to a new {{Sanitizer}} whose [=Sanitizer/configuration=] is the result of [=canonicali`ze the configuration|canonicalizing=] |sanitizer|'s [=Sanitizer/configuration=].


Shouldn't that already be canonicalized?

This is the equivalent of cloning, to avoid mutating an existing object. The note underneath says so

Refactored this, doesn't use "canonicalize" anymore.

annevk · 2026-06-22T06:49:04Z

Also, reportedly this impacts innerHTML and friends as well somehow? I think that warrants some examples.

noamr · 2026-06-23T10:50:09Z

Also, reportedly this impacts innerHTML and friends as well somehow? I think that warrants some examples.

Added prose and examples for this

noamr · 2026-06-23T10:59:29Z

(The build failure is in main, trying to resolve separately. Do you have an idea maybe @lukewarlow ?)

evilpie · 2026-06-23T11:29:17Z

In TrustedParserOptions sanitizer member is readonly, but a Sanitizer instance allows for internal modification. Isn't that unexpected?

Also I feel like we should probably always return a Sanitizer object, instead of one of three options? Otherwise it seems easy to accidentally write code (not sure what for though?) that only works with a subset.

noamr · 2026-06-23T11:33:59Z

In TrustedParserOptions sanitizer member is readonly, but a Sanitizer instance allows for internal modification. Isn't that unexpected?

It's a good point. I guess we need to return a clone of the underlying sanitizer if the getter is invoked so that you couldn't get a TrustedParserOptions and then mutate it.

Also I feel like we should probably always return a Sanitizer object, instead of one of three options? Otherwise it seems easy to accidentally write code (not sure what for though?) that only works with a subset.

Yea I was contemplating that. SGTM

`createParserOptions` receives a `SetHTML{Unsafe}Options` and turns them into a `TrustedParserOptions` using the given method from the policy config. This is the `trusted-types` part of #594 (Need to wire it to HTML as well)

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

noamr · 2026-06-23T13:12:10Z

In TrustedParserOptions sanitizer member is readonly, but a Sanitizer instance allows for internal modification. Isn't that unexpected?

It's a good point. I guess we need to return a clone of the underlying sanitizer if the getter is invoked so that you couldn't get a TrustedParserOptions and then mutate it.

Also I feel like we should probably always return a Sanitizer object, instead of one of three options? Otherwise it seems easy to accidentally write code (not sure what for though?) that only works with a subset.

Yea I was contemplating that. SGTM

The new version only passes a Sanitizer option around, and mutating a trustedParserOptions.sanitizer doesn't affect the underlying sanitizer.

noamr requested a review from lukewarlow February 17, 2026 11:13

noamr mentioned this pull request Feb 17, 2026

Streaming support #594

Open

lukewarlow reviewed Feb 17, 2026

View reviewed changes

Comment thread spec/index.bs Outdated

lukewarlow reviewed Feb 17, 2026

View reviewed changes

Comment thread spec/index.bs Outdated

kkoyung mentioned this pull request May 28, 2026

Implement Sanitizer API servo/servo#43948

Open

24 tasks

noamr force-pushed the create-parser-options branch from ced3862 to d44dcea Compare June 1, 2026 13:44

noamr closed this Jun 9, 2026

noamr reopened this Jun 9, 2026

annevk reviewed Jun 22, 2026

View reviewed changes

noamr and others added 12 commits June 23, 2026 13:32

Update TrustedParserOptions to expose only Window

a8a4cd1

Update index.bs

5220b47

Introduce runScripts and potentially "throw if missing"

9216635

mutation

0e57a69

Wrap createHTML+createParserOptions

1f6c317

Add prose and examples for createParserOptions

7717fd8

Fix build

9626ec5

Update spec/index.bs

e14e85b

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

Update spec/index.bs

1ccdbe9

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

Update spec/index.bs

fdbbfae

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

nits

5db0166

noamr force-pushed the create-parser-options branch from 6b671ea to 5db0166 Compare June 23, 2026 12:33

noamr added 2 commits June 23, 2026 13:59

Ensure mutations in place don't work

2197e7a

biblio

3597b91


		## Get Trusted Type parser input ## {#get-trusted-type-parser-input-algorithm}

		To <dfn export>get Trusted Type compliant input</dfn> given a {{TrustedType}} \|expectedType\|, a [=realm/global object=] (\|global\|), string, or <code data-x="">Stream</code> \|input\|,

Uh oh!

Conversation

noamr commented Feb 17, 2026 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukewarlow commented Feb 17, 2026

Uh oh!

noamr commented Jun 1, 2026

Uh oh!

lukewarlow commented Jun 9, 2026

Uh oh!

noamr commented Jun 9, 2026

Uh oh!

annevk Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

noamr Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annevk Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

noamr Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

noamr Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

annevk commented Jun 22, 2026

Uh oh!

noamr commented Jun 23, 2026

Uh oh!

noamr commented Jun 23, 2026

Uh oh!

evilpie commented Jun 23, 2026

Uh oh!

noamr commented Jun 23, 2026

Uh oh!

noamr commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

noamr commented Feb 17, 2026 •

edited by pr-preview Bot

Loading